Comments on: Faster Rectangle Class

By: Stephen Calender

Stephen Calender — Fri, 12 Aug 2011 06:40:36 +0000

This is a good question. For simple data structure like classes like points, vectors, and in this case rectangles I typically break the encapsulation rule of OOP. Notice that I left the class members rx and ry public and rwidth and rheight as internal. Since Flash is pass by value (you get a copy of the data, not the actual reference to the data) for the simple data types (Boolean, Uint, Int, Number, String) using a getter function is actually a pretty heavy operation since it creates memory. If I wanted to maintain top, bottom, left, and right I would have to either always calculate them on the fly or enforce the use of setter functions for x, y, width, and height (more memory allocations). I provided getters and setters as a courtesy to those that would frown on this practice, I personally avoid using getters and setters if I think I can get away with it. Data structures for basic geometry have a pretty standard implementation, so it felt like it made sense.

It was a tough call to make, the logic for my intersect and intersection functions would be clearer with those logical reference points. However, I think I clocked the weight of a memory allocation / creating local variables in another post far exceeding the cost of some additional math. Every programmer is different, we all weigh the pros and cons differently, I put a high value on speed, particularly with data structures.

By: Kenny

Kenny — Fri, 12 Aug 2011 00:55:42 +0000

Is there a reason you omitted the public properties such as ‘left’, ‘top’, etc.?

By: Tweets that mention Stephen Calender Programming Blog -- Topsy.com

Tweets that mention Stephen Calender Programming Blog -- Topsy.com — Mon, 15 Nov 2010 12:58:50 +0000

[...] This post was mentioned on Twitter by Snorre Berge, Stephen Calender. Stephen Calender said: Its been a while but the blog is alive again: http://www.stephencalenderblog.com/?p=293 something for the Fellow Flash Developers [...]

By: Todd

Todd — Mon, 15 Nov 2010 11:43:19 +0000

It doesn’t surprise me that their code would be clunkier. When dealing with a development team with several hundred coders, I’m guessing not everyone is doing their best to optimize each class.

Also, I would venture to say they were not focused on this entirely because their target market doesn’t do this type of development much. Kind of like when there were all those companies doing 3d-esque engines with Flash, and Adobe didn’t touch it; after a few years, they built their own into the IDE (if they didn’t just buy one of the companies outright).

Good stuff!